Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12398 )
Change subject: remove code dup: add msc_mgcp_try_call_assignment() ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12398/3/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: https://gerrit.osmocom.org/#/c/12398/3/src/libmsc/msc_mgcp.c@964 PS3, Line 964: return 0; > Maybe it's a good idea to print some NOTICE here? No: if we've already done the Assignment step before, subsequent attempts should just silently not do anything. No use to keep logging "Assignment happened some time ago" over and over. The msc_mgcp_try_call_assignment() is called three or four times during call establishing, only one will trigger an Assignment. https://gerrit.osmocom.org/#/c/12398/3/src/libmsc/msc_mgcp.c@966 PS3, Line 966: trans->assignment_done = true; > Ah, ok. The following commit renames this flag, so it's much cleaner. exactly; 'assignment_done' also confused me, it will be renamed to 'assignment_started'. -- To view, visit https://gerrit.osmocom.org/12398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c0b7dc3f1a747028629b48e522bb3b864884ba Gerrit-Change-Number: 12398 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 04 Jan 2019 01:45:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
