Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/5746 )
Change subject: Checking in pySim-fairwaves-prog.py utility. ...................................................................... Patch Set 1: Code-Review-1 I think the proper way to go about this is not to have a vendor-specific program in pySim-prog, but to implement this properly, i.e. have the same feature sset irrespective of the used card, and have parser/input plugins for different CSV formats used. It could very well be a different command/program/"main-file", than the existing somewhat unintuitive pySim-prog, but in general we should implement the same functionality / usage for all supported cards. -- To view, visit https://gerrit.osmocom.org/5746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f58e1b45d1785d59cef161eab1388332a97936b Gerrit-Change-Number: 5746 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Kévin Redon <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Fri, 04 Jan 2019 07:52:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
