Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12469 )
Change subject: add osmo_lu_type_names[], osmo_lu_type_name() ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/12469/2/src/gsm/gsm48.c File src/gsm/gsm48.c: https://gerrit.osmocom.org/#/c/12469/2/src/gsm/gsm48.c@1141 PS2, Line 1141: GSM48_LUPD_NORMAL BTW: what about GSM48_LUPD_RESERVED? https://gerrit.osmocom.org/#/c/12469/2/src/gsm/gsm48.c@1144 PS2, Line 1144: {} cosmetic: in other 'value_string' statements of this file '{ 0, NULL }' is used. -- To view, visit https://gerrit.osmocom.org/12469 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica25919758ef6cba8348da199b0ae7e0ba628798 Gerrit-Change-Number: 12469 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sat, 05 Jan 2019 11:44:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
