Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12468 )
Change subject: add osmo_mi_name(), for MI-to-string like "IMSI-123456" ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/12468/2/src/gsm/gsm48.c File src/gsm/gsm48.c: https://gerrit.osmocom.org/#/c/12468/2/src/gsm/gsm48.c@441 PS2, Line 441: mi[] > I know that an array in C is basically a pointer to its first […] '*' is fine with me. Argument wise, to me any array would make more sense to be indicated by [], be it of uint8_t or complex structs. A pointer * would be more suitable for a pointer to a single element. At osmocom however we tend to only do * and never [], except for 'extern const struct value_string foo_names[];' I've had the same code review argument recently, I don't think it's worth arguing against foo[] if it is an array of any kind, but if you guys are so fixed on plain pointers, fine with me. https://gerrit.osmocom.org/#/c/12468/2/src/gsm/gsm48.c@451 PS2, Line 451: default > We usually put the 'default' statement below all 'case' statements. […] no reason nor preference on my side -- To view, visit https://gerrit.osmocom.org/12468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7798c3ef983c2e333b2b9cbffef6f366f370bd81 Gerrit-Change-Number: 12468 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sun, 06 Jan 2019 21:53:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
