Max has posted comments on this change. ( https://gerrit.osmocom.org/11991 )
Change subject: libmsc/gsm_04_80.c: HACK: reimplement GSM 04.08 RELEASE COMPLETE ...................................................................... Patch Set 4: Code-Review-1 It's good that it's posted as a reference point for future libosmocore implementation but I don't see a pressing need to get this merge into master just to get it removed some time later. We might as well keep it WIP and wait for "some time later" to merge the proper version right away. -- To view, visit https://gerrit.osmocom.org/11991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89727354385b40e18732e8fd1d6c93f4463ade37 Gerrit-Change-Number: 11991 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 10:35:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
