dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12482
Change subject: paging: fix nullpointer deref
......................................................................
paging: fix nullpointer deref
In theroy the finction T_def_get_entry() may return a nullpointer. In
this case we would run straight into a nullpointer dereference problem.
However, the requested timer is statically defined and should always be
there. However Coverity still reports this as a problem. Lets put an
OSMO_ASSERT to make clear that there is no problem here.
Fixes: CID#190403
Change-Id: If5238132d9d5a1507b9955a0b2dc4b1bced220e8
---
M src/osmo-bsc/paging.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/12482/1
diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c
index 2c9d5cd..066db1c 100644
--- a/src/osmo-bsc/paging.c
+++ b/src/osmo-bsc/paging.c
@@ -296,6 +296,11 @@
unsigned int to_us, to;
struct T_def *d = T_def_get_entry(bts->network->T_defs, 3113);
+ /* Note: d should always contain a valid pointer since all timers,
+ * including 3113 are statically pre-defined in
+ * struct T_def gsm_network_T_defs. */
+ OSMO_ASSERT(d);
+
if (!bts->T3113_dynamic)
return d->val;
--
To view, visit https://gerrit.osmocom.org/12482
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5238132d9d5a1507b9955a0b2dc4b1bced220e8
Gerrit-Change-Number: 12482
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
