Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12416 )
Change subject: tests: Rework the convolve_test ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52M/convolve_test.c File tests/Transceiver52M/convolve_test.c: https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52M/convolve_test.c@106 PS4, Line 106: enum { You could make this enum named (move it out of struct test_data) and then use it as parameter in run_convolve to make parameter "int test" easier to read and understand. https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52M/convolve_test.c@226 PS4, Line 226: case CONV_REAL_OPT: missing break? Otherwise add /* fall through */ https://gerrit.osmocom.org/#/c/12416/4/tests/Transceiver52M/convolve_test.c@233 PS4, Line 233: case CONV_COMPLEX_BASE: missing break? Otherwise add /* fall through */ -- To view, visit https://gerrit.osmocom.org/12416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e203d2c4b778af77d630ed15d4cef6b0c0eb76d Gerrit-Change-Number: 12416 Gerrit-PatchSet: 4 Gerrit-Owner: tnt <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 17:46:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
