Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12415 )
Change subject: convolve: Remove support for step, offset parameters ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Looks fine, just a few cosmetic issues. https://gerrit.osmocom.org/#/c/12415/1/Transceiver52M/arch/common/convolve_base.c File Transceiver52M/arch/common/convolve_base.c: https://gerrit.osmocom.org/#/c/12415/1/Transceiver52M/arch/common/convolve_base.c@46 PS1, Line 46: for (int i=0; i<len; i++) Usually all arithmetic operators are space-separated. https://gerrit.osmocom.org/#/c/12415/1/tests/Transceiver52M/convolve_test.c File tests/Transceiver52M/convolve_test.c: https://gerrit.osmocom.org/#/c/12415/1/tests/Transceiver52M/convolve_test.c@93 PS1, Line 93: x-30,2*x_len+30 same here https://gerrit.osmocom.org/#/c/12415/1/tests/Transceiver52M/convolve_test.c@95 PS1, Line 95: 2*h_len and here -- To view, visit https://gerrit.osmocom.org/12415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic850269a0ed5d98c0ea68980afd31016ed555b48 Gerrit-Change-Number: 12415 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 02:53:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
