osmith has posted comments on this change. ( https://gerrit.osmocom.org/12524 )
Change subject: gsm23003: add osmo_imei_str_valid() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12524/1/src/gsm/gsm23003.c File src/gsm/gsm23003.c: https://gerrit.osmocom.org/#/c/12524/1/src/gsm/gsm23003.c@75 PS1, Line 75: the 15th check digit is not : * intended for digital transmission. > Ok, got it! […] I think that we want to be sure if we are dealing with the 14 digits variant, or the 15 digits variant. So if we make it possible to verify the check digit too, I would add a parameter to the function. Something like that: osmo_imei_str_valid(const char *imei, bool check_digit); Would you prefer if I implement it that way? -- To view, visit https://gerrit.osmocom.org/12524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2d2a3a93b033bafc74c62e15297034bf4aafe61 Gerrit-Change-Number: 12524 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jan 2019 13:26:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No