Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12522 )
Change subject: mm_rx_id_resp(): use osmo_mi_name() ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Fine excluding some cosmetic comments. https://gerrit.osmocom.org/#/c/12522/2/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/#/c/12522/2/src/libmsc/gsm_04_08.c@293 PS2, Line 293: data+1 Please use spaces, i.e. '... data + 1'. https://gerrit.osmocom.org/#/c/12522/2/src/libmsc/gsm_04_08.c@294 PS2, Line 294: mi_len Placing this variable before the *mi would make the code a bit more readable. While reading 'gh->data+1' I was wondering why do you skip one byte... -- To view, visit https://gerrit.osmocom.org/12522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bb053def223ed698351ad9f52c1e36293df5d59 Gerrit-Change-Number: 12522 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 11 Jan 2019 14:06:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
