Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12505 )
Change subject: declare variables so the main loop can read the data to be flashed provided by the USB stack ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/12505/1/usb/class/dfu/device/dfudf.c File usb/class/dfu/device/dfudf.c: https://gerrit.osmocom.org/#/c/12505/1/usb/class/dfu/device/dfudf.c@37 PS1, Line 37: enum usb_dfu_state dfu_state = USB_DFU_STATE_DFU_IDLE; : enum usb_dfu_status dfu_status = USB_DFU_STATUS_OK; : : uint8_t dfu_download_data[512]; : uint16_t dfu_download_length = 0; : size_t dfu_download_progress = 0; : bool dfu_manifestation_complete = false; you could wrapp all of these into some 'struct dfu_state' and then have one 'struct dfu_state g_dfu' or something like that to avoid cluttering lots of global symbols in the namespace. But that's just a thought, nothing required. -- To view, visit https://gerrit.osmocom.org/12505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I092357aad95abef1a781be1ea77944f2ea523dab Gerrit-Change-Number: 12505 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 11 Jan 2019 17:15:02 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
