Max has posted comments on this change. ( https://gerrit.osmocom.org/12491 )
Change subject: LCLS: add allocator function ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12491/1/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/#/c/12491/1/src/gsm/gsm0808_utils.c@587 PS1, Line 587: r->gcr = talloc_zero(r, struct osmo_gcr_parsed); > please remind me, why again was the gcr member not a static member of the > struct osmo_lcls and has t […] GCR is optional in a sense that it's possible that we might have other osmo-lcls set while GCR is missing. Right now this is indicated by NULL pointer in place of GCR. I can make it static and add bool gcr_available to distinguish between "no GCR" and "GCR is all 0" cases. Which one would be better option? -- To view, visit https://gerrit.osmocom.org/12491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If67cf93ae3dd449e96156485fe1baaf013df3f77 Gerrit-Change-Number: 12491 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Mon, 14 Jan 2019 10:16:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
