Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12441 )
Change subject: layer23/sap_interface.c: reimplement (BT)SAP interface ...................................................................... Patch Set 8: (4 comments) https://gerrit.osmocom.org/#/c/12441/8//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12441/8//COMMIT_MSG@12 PS8, Line 12: a Bluetooth link. > Do you have a link to that part of BT spec by any chance? If so, would be > cool to add it here or in […] The specifications of core profiles can be found at https://www.bluetooth.com/specifications/profiles-overview. The problem is that link to SAP is probably the only one that redirects to registration form :/ I only managed to find *.pdf using Google. https://gerrit.osmocom.org/#/c/12441/8//COMMIT_MSG@61 PS8, Line 61: only imitation is Server-initiated Release, that allows the > typo Done https://gerrit.osmocom.org/#/c/12441/8//COMMIT_MSG@64 PS8, Line 64: implemented (yet), and leds to immediate release. > here too. Done https://gerrit.osmocom.org/#/c/12441/8/src/host/layer23/src/common/sap_fsm.c File src/host/layer23/src/common/sap_fsm.c: https://gerrit.osmocom.org/#/c/12441/8/src/host/layer23/src/common/sap_fsm.c@186 PS8, Line 186: /* Sent ATR request (required by the specs) */ > Do you recall particular section? Thanks, this note helped me to fix a bug ;) ATR shall be sent only if card state is "Card reset". -- To view, visit https://gerrit.osmocom.org/12441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77bb108615bb2c94c441568f195b04e0a5421643 Gerrit-Change-Number: 12441 Gerrit-PatchSet: 8 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Kévin Redon <kre...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Mon, 14 Jan 2019 21:29:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No