Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12493 )

Change subject: LCLS: add GCR comparison helper
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12493/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12493/2//COMMIT_MSG@7
PS2, Line 7: add GCR comparison helper
> The GCR comparison helper will be used to compare GCRs.

Yes, it can be seen from the commit name, but my question was different.
In other words, which projects would benefit from this helper?

> In fact, it's already used in this patch in the test.

I see. At the same time, it isn't covered by test(s) itself ;)



--
To view, visit https://gerrit.osmocom.org/12493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3b5560a058b976638d03cb819415d237ae9984
Gerrit-Change-Number: 12493
Gerrit-PatchSet: 2
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-CC: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Mon, 14 Jan 2019 23:59:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to