Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12527 )
Change subject: VTY: integrate IMEI ...................................................................... Patch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12527/5/tests/test_subscriber.vty File tests/test_subscriber.vty: https://gerrit.osmocom.org/#/c/12527/5/tests/test_subscriber.vty@34 PS5, Line 34: % No subscriber for msisdn = '12345' actually you should also add tests for the imei selector, basically copy-pasting "all" of those present for msisdn -- To view, visit https://gerrit.osmocom.org/12527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30 Gerrit-Change-Number: 12527 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jan 2019 16:10:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes