osmith has posted comments on this change. ( https://gerrit.osmocom.org/12478 )
Change subject: VLR: send CHECK-IMEI to EIR/HLR ...................................................................... Patch Set 11: (1 comment) https://gerrit.osmocom.org/#/c/12478/11/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/12478/11/src/libvlr/vlr.c@664 PS11, Line 664: {0} > Do we really need to zero-init this array? We don't, as gsm48_encode_bcd_number() doesn't read from this buffer before writing to it. I've verified this with valgrind just to be sure. The {0} is removed now, thanks for pointing it out! -- To view, visit https://gerrit.osmocom.org/12478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife868ed71c36cdd02638072abebf61fc949080a7 Gerrit-Change-Number: 12478 Gerrit-PatchSet: 11 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 10:36:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
