Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12572 )
Change subject: Change GSM48_PDISC_* to enum type ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12572/2/include/osmocom/gsm/protocol/gsm_04_08.h File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/#/c/12572/2/include/osmocom/gsm/protocol/gsm_04_08.h@1355 PS2, Line 1355: enum osmo_pdisc { I do think some sort of layer name should be in there, just osmo_pdisc is too general. Given the value names I guess Vadim's choice is fair enough. But on a meta level let's first discuss your plans for osmo-msc. -- To view, visit https://gerrit.osmocom.org/12572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbbe8786a776081d7643193f154e6270224399e6 Gerrit-Change-Number: 12572 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 12:02:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
