Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12564 )
Change subject: MNCC: move messages into public header and convert to enum ...................................................................... Patch Set 1: Code-Review-2 (5 comments) I don't understand why you are coming up with this. https://gerrit.osmocom.org/#/c/12564/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12564/1//COMMIT_MSG@7 PS1, Line 7: MNCC: move messages into public header and convert to enum why??? https://gerrit.osmocom.org/#/c/12564/1/include/osmocom/gsm/mncc.h File include/osmocom/gsm/mncc.h: https://gerrit.osmocom.org/#/c/12564/1/include/osmocom/gsm/mncc.h@81 PS1, Line 81: GSM_TCHF_FRAME = 0x0300, rather first drop these along with RTP frame forwarding on mncc in a separate commit? https://gerrit.osmocom.org/#/c/12564/1/src/gsm/mncc.c File src/gsm/mncc.c: https://gerrit.osmocom.org/#/c/12564/1/src/gsm/mncc.c@a96 PS1, Line 96: silently dropping these https://gerrit.osmocom.org/#/c/12564/1/src/gsm/mncc.c@37 PS1, Line 37: /* FIXME FIXME FIXME FIXME FIXME START */ this looked like it referred to the MNCC defines, now it's left behind on its own? doesn't look useful anyway. https://gerrit.osmocom.org/#/c/12564/1/src/gsm/mncc.c@111 PS1, Line 111: /* FIXME FIXME FIXME FIXME FIXME END */ wtf :) -- To view, visit https://gerrit.osmocom.org/12564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie808b42871d3847b6b47964d9b0504b3c51c2fd0 Gerrit-Change-Number: 12564 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 12:52:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
