Max has posted comments on this change. ( https://gerrit.osmocom.org/12554 )
Change subject: socket: add define for socket name length ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12554/2/src/socket.c File src/socket.c: https://gerrit.osmocom.org/#/c/12554/2/src/socket.c@786 PS2, Line 786: /* "r=1.2.3.4:123<->l=5.6.7.8:987" */ It might make sense to move the comment as well: the format is explained in doxygen already. Without this comments it completely unclear where all the ..+ 1 + 5... come from. -- To view, visit https://gerrit.osmocom.org/12554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8be8c2c0d4935da17ab13b2c2127b719ceefbcc Gerrit-Change-Number: 12554 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 15:49:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
