Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/12596 )
Change subject: Log MDCX ACK for established lchan
......................................................................
Log MDCX ACK for established lchan
Previously LCHAN_RTP_EV_IPACC_MDCX_ACK was not permitted for
LCHAN_RTP_ST_ESTABLISHED state in lchan FSM. However this message is
normal in case of LCLS loop closed via IPA (as opposed to MGCP). Let's
permit this message and log it to make debug output easier to read.
Change-Id: Ib642df799f3405c4d707eb57b2ebc84386d7f03f
Related: OS#2487
---
M src/osmo-bsc/lchan_rtp_fsm.c
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Vadim Yanitskiy: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c
index 84cc287..2d15bf2 100644
--- a/src/osmo-bsc/lchan_rtp_fsm.c
+++ b/src/osmo-bsc/lchan_rtp_fsm.c
@@ -565,13 +565,19 @@
static void lchan_rtp_fsm_established(struct osmo_fsm_inst *fi, uint32_t
event, void *data)
{
+ struct gsm_lchan *lchan = lchan_rtp_fi_lchan(fi);
+
switch (event) {
case LCHAN_RTP_EV_RELEASE:
case LCHAN_RTP_EV_ROLLBACK:
osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, 0);
return;
-
+ case LCHAN_RTP_EV_IPACC_MDCX_ACK:
+ LOG_LCHAN_RTP(lchan, LOGL_NOTICE,
+ "Received MDCX ACK on established lchan's RTP
port: %s\n",
+ mgwep_ci_name(lchan->mgw_endpoint_ci_bts));
+ return;
default:
OSMO_ASSERT(false);
}
@@ -689,6 +695,7 @@
.in_event_mask = 0
| S(LCHAN_RTP_EV_RELEASE)
| S(LCHAN_RTP_EV_ROLLBACK)
+ | S(LCHAN_RTP_EV_IPACC_MDCX_ACK)
,
},
[LCHAN_RTP_ST_ROLLBACK] = {
--
To view, visit https://gerrit.osmocom.org/12596
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib642df799f3405c4d707eb57b2ebc84386d7f03f
Gerrit-Change-Number: 12596
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
