Max has posted comments on this change. ( https://gerrit.osmocom.org/12483 )

Change subject: LCLS: add status parameter to Assignment Completed message
......................................................................


Patch Set 4:

(2 comments)

This change is ready for review.

https://gerrit.osmocom.org/#/c/12483/2/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/12483/2/src/gsm/gsm0808.c@522
PS2, Line 522: /*! Create BSSMAP Assignment Completed message as per 3GPP TS 
48.008 ยง3.2.1.2
> (end with dot)
Done


https://gerrit.osmocom.org/#/c/12483/2/src/gsm/gsm0808.c@537
PS2, Line 537:                                 enum gsm0808_lcls_status 
lcls_bss_status)
> looks like wrong indent on gerrit
Looks fine in Emacs.



--
To view, visit https://gerrit.osmocom.org/12483
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547c6b8707123aa8c1ef636db88908df112d90a4
Gerrit-Change-Number: 12483
Gerrit-PatchSet: 4
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Comment-Date: Thu, 17 Jan 2019 15:58:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to