osmith has posted comments on this change. ( https://gerrit.osmocom.org/12527 )
Change subject: VTY: integrate IMEI ...................................................................... Patch Set 8: > generally I wonder whether we should just always drop that luhn check digit > and only handle 14 digit IMEIs. Would that simplify anything? I would rather keep it, it seems to be an useful feature to me and it is already implemented and working. I'll create a new patch that addresses the points you mentioned, thanks for the review. -- To view, visit https://gerrit.osmocom.org/12527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1af7b573ca2a1cb22497052665012d9c1acf3b30 Gerrit-Change-Number: 12527 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Mon, 21 Jan 2019 15:49:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
