Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 )
Change subject: Store subscriber's cell identity in ran_conn ...................................................................... Patch Set 6: (1 comment) > Meta: AFAIK we already store the entire CGI in the vlr_subscr? > maybe we should instead drop the LAC info from struct ran_conn completely? Fine by me. > (code looks like we are never storing the CI part of vls_subscr->cgi, that > would be nice to fix) The question is if it's ok to use vls_subscr's CGI - do we have 1:1 relation between ran_conn and vls_subscr after your handover changes? > Meta meta: in the course of inter-MSC HO I am refactoring what the ran_conn > represents, so I'd prefer to park this patch and revisit after the inter-MSC > changes, to avoid merge conflicts and back-and-forths. I understand your concerns although it's kinda inconvenient to halt all OsmoMSC development until you're done with HO. Any chance you could start pushing ran_conn related changes to gerrit perhaps? https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c@320 PS2, Line 320: case CELL_IDENT_CI: > a CELL_IDENT_CI is *only* a CI without a LAC; So it's impossible to have CI without LAC? Do you have a spec reference I can add in here instead of FIXME? -- To view, visit https://gerrit.osmocom.org/11746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8544c30ea800ce8356a227b03a8b21bf3252be7e Gerrit-Change-Number: 11746 Gerrit-PatchSet: 6 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 24 Jan 2019 12:11:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
