Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12679 )
Change subject: bsc_vty: add vty command to display all lchans ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12679/1/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/12679/1/src/osmo-bsc/bsc_vty.c@1576 PS1, Line 1576: "show lchan all [<0-255>] [<0-255>] [<0-7>] [<0-7>]", we talked in person and the result is that 'show lchan summary-all' is a good compromise, and otherwise this patch is completely fine. (the 'all' flag could be implemented differently, but it's a bikeshed from me) -- To view, visit https://gerrit.osmocom.org/12679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4d763476905fa8f84b4d7cdad4cc7dd879f84a5 Gerrit-Change-Number: 12679 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 24 Jan 2019 15:31:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
