Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12654 )
Change subject: Log peer's port in accept callback ...................................................................... Patch Set 1: It's great that you want to add useful information. However, removing other useful information (like to which local port) is not good. Thre are many interfaces that use IPA (Abis, SCCPlite, CTRL, GSUP, ...) and the local port number could help to determine which of those the message relates to. Maybe use the full tuple and use osmo_sock_get_name2() instead? -- To view, visit https://gerrit.osmocom.org/12654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55 Gerrit-Change-Number: 12654 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Thu, 24 Jan 2019 17:20:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
