Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12671 )
Change subject: add osmo_hexdump_b(), osmo_hexdump_nospc_b() ...................................................................... Patch Set 2: I am not a friend of those functions. In the end, we will have "second static buffer" versions of all of our functions, and megabytes of static buffers. I think if it's needed twice in one "printf" statement, the caller will simply use the _buf() variant and put the buffer on the local stack of the caller. -- To view, visit https://gerrit.osmocom.org/12671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia48fc6b984f06b972a6846b173b8cf8d30737460 Gerrit-Change-Number: 12671 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Thu, 24 Jan 2019 18:26:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
