Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12695 )

Change subject: osmo-*/Dockerfile: fix default run command
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/12695/1/osmo-bsc-master/Dockerfile
File osmo-bsc-master/Dockerfile:

https://gerrit.osmocom.org/#/c/12695/1/osmo-bsc-master/Dockerfile@45
PS1, Line 45: "-c", "/data/osmo-bsc.cfg"
By default, if -c is not specified, osmo-bsc should look for osmo-bsc.cfg in 
the current directory.


https://gerrit.osmocom.org/#/c/12695/1/osmo-sip-latest/Dockerfile
File osmo-sip-latest/Dockerfile:

https://gerrit.osmocom.org/#/c/12695/1/osmo-sip-latest/Dockerfile@30
PS1, Line 30: "-M", "/data/unix/mncc"
AFAIK, there is no such argument.


https://gerrit.osmocom.org/#/c/12695/1/osmo-sip-master/Dockerfile
File osmo-sip-master/Dockerfile:

https://gerrit.osmocom.org/#/c/12695/1/osmo-sip-master/Dockerfile@49
PS1, Line 49: "-M", "/data/unix/mncc"
same



--
To view, visit https://gerrit.osmocom.org/12695
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60096406e08641cc3aaab0f77d7491df39475feb
Gerrit-Change-Number: 12695
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Fri, 25 Jan 2019 15:52:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to