Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12705 )
Change subject: Drop unused parameter ...................................................................... Patch Set 1: don't you think the bug is rather that the talloc inside value_node_add is using 'parent' instead of 'ctx'? I don't recall the details. My suspicion is that originally not all nodes were dynamically allocated and hence the ctx would need to be specified explicitly. If that's no longer the case, than it appears we can go for removing the argument like in your patch. -- To view, visit https://gerrit.osmocom.org/12705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17c2fed4049e1c83307feda001aefc006dfbe6a3 Gerrit-Change-Number: 12705 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Sun, 27 Jan 2019 13:45:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
