osmith has posted comments on this change. ( https://gerrit.osmocom.org/12318 )
Change subject: ctrl: log host/port on errors ...................................................................... Patch Set 5: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12318/4/src/simple_ctrl.c File src/simple_ctrl.c: https://gerrit.osmocom.org/#/c/12318/4/src/simple_ctrl.c@40 PS4, Line 40: #define CTRL_ERR(cfg, fmt, args...) fprintf(stderr, "CTRL %s:%u error: " fmt, cfg->remote_host, cfg->remote_port, ##args) This line is longer than 120 characters, which is the max allowed length defined here: https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards https://gerrit.osmocom.org/#/c/12318/4/src/simple_ctrl.c@103 PS4, Line 103: struct ctrl_cfg *cfg; Pau asked in your other path: > Do we really need a pointer allocated by talloc here? and an alloc function? > just to have 2 strings and one int, all this seems overengineered to me. https://gerrit.osmocom.org/#/c/osmo-sysmon/+/12316/2/src/osysmon_ctrl.c@41 Then you changed it to "struct ctrl_cfg cfg;". So shouldn't it be the same here for consistency? -- To view, visit https://gerrit.osmocom.org/12318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I788d51359965a66c54075a3971aa7824c3bfb0bf Gerrit-Change-Number: 12318 Gerrit-PatchSet: 5 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Mon, 28 Jan 2019 15:21:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
