Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling ...................................................................... Patch Set 8: (1 comment) https://gerrit.osmocom.org/#/c/12682/8/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/12682/8/src/mncc.c@429 PS8, Line 429: osmo_strlcpy((char *)data->called.number, "emergency", sizeof(data->called.number)); > The original author made data const on purpose: the buffer passed into this > function must not be mod […] Also, most of the emergency number's fields are now possibly random bytes, since the MNCC_F_CALLED flag indicated that no called number field was present at all. Also the if cascade is a bit weird. To make your life a bit simpler, let me suggest a way to do it in a new patch set. -- To view, visit https://gerrit.osmocom.org/12682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 8 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 29 Jan 2019 00:53:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
