Max has posted comments on this change. ( https://gerrit.osmocom.org/12711 )
Change subject: Update Makefile.am ...................................................................... Patch Set 4: (1 comment) This change is ready for review. https://gerrit.osmocom.org/#/c/12711/2/.gitignore File .gitignore: https://gerrit.osmocom.org/#/c/12711/2/.gitignore@62 PS2, Line 62: libintern.la > let's please keep the 'simlpe_ctrl' in the name. Another patch (WIP) will add OpenVPN probe which will use generic tcp client which might be reused by simple_ctrl and end-up in convenience library as well. Maybe call it libinternal as in latest revision to keep it more generic? -- To view, visit https://gerrit.osmocom.org/12711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idfaba17b54983709278e1c24bf55edbbb4abd961 Gerrit-Change-Number: 12711 Gerrit-PatchSet: 4 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 29 Jan 2019 15:51:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
