osmith has posted comments on this change. ( https://gerrit.osmocom.org/12710 )
Change subject: Add ping probe support ...................................................................... Patch Set 9: Code-Review-1 (2 comments) It seems like config.h is not needed, otherwise everything looks fine to me. https://gerrit.osmocom.org/#/c/12710/9//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12710/9//COMMIT_MSG@29 PS9, Line 29: nitpick: empty line here https://gerrit.osmocom.org/#/c/12710/9/src/osysmon.h File src/osysmon.h: https://gerrit.osmocom.org/#/c/12710/9/src/osysmon.h@9 PS9, Line 9: #include "config.h" Why is config.h needed? -- To view, visit https://gerrit.osmocom.org/12710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife32540b532fb54368f63c78fb7837b84d4e8c76 Gerrit-Change-Number: 12710 Gerrit-PatchSet: 9 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 15:14:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
