Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12716 )
Change subject: osmo_fsm_inst_state_chg(): clamp timeout_secs to <= ~68 years ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12716/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12716/3//COMMIT_MSG@13 PS3, Line 13: use a reasonable : maximum value of signed 64 bit integer > I think the actual value used is that of a signed 32bit integer? oof! gosh, how did I get that wrong. I guess 32 bit is sufficient then and also gets us to be safe on 32bit time_t systems. -- To view, visit https://gerrit.osmocom.org/12716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35ec4654467b1d6040c8aa215049766089e5e64a Gerrit-Change-Number: 12716 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 16:38:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
