Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12765 )
Change subject: Add missing include ...................................................................... Patch Set 1: Code-Review+2 I agree osmith's suggestion is much better than the current summary. But we also should make sure we find the right compromise regarding investment of all our limited time. This kind of commit is so trivial that it's unlikely going to be something that ever receives much scrutiny or will raise the interest of a future reader of the commitlog.... -- To view, visit https://gerrit.osmocom.org/12765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b4f4965af0fefa7dac3f2a56a5a4b76a03fd57 Gerrit-Change-Number: 12765 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pablo Neira Ayuso <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 21:17:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
