Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12829 )
Change subject: gsm0808: Add CSFB indication IE to BSSMAP CLEAR COMMAND ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12829/1/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/12829/1/src/gsm/gsm0808.c@202 PS1, Line 202: struct msgb *gsm0808_create_clear_command2(uint8_t cause, bool csfb_ind) as an alternative to all those "foo2()" functions, one could also have gone for a "gsm0808_append_csfb_ind(struct msgb *)" function, which would then simply be a wrapper for msgb_v_put() and hence also be an inline function. I would personally find that cleaner in terms of API design, but I'll leave it up to you. -- To view, visit https://gerrit.osmocom.org/12829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8a75e1da2d5f520064666e4ee413d1c91da6ae3 Gerrit-Change-Number: 12829 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Mon, 04 Feb 2019 19:52:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
