Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12830 )
Change subject: a_iface: Include CSFB Indication into BSSMAP CLEAR COMMAND ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12830/1/src/libmsc/a_iface.c File src/libmsc/a_iface.c: https://gerrit.osmocom.org/#/c/12830/1/src/libmsc/a_iface.c@424 PS1, Line 424: vsub && vsub->sgs_fsm->state == SGS_UE_ST_ASSOCIATED I don't recall all the SGs details anymore. Is it guaranteed that the call was CSFB related if we are in that state? What if we are in SGS associated and a phone might for whatever reasons (e.g. loss of 4G coverage) have returned to 2G/3G? We'd have invalidated the state then already before? I guess what I'd ideally be hoping for is that we somehow *know* that this particular call was established via CSFB, rather than relying on some "global" state of the subscriber. Not super critical, just my 2 cents. -- To view, visit https://gerrit.osmocom.org/12830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cfa4b3becdd0138d74e2e1eddd83a0b1568c1de Gerrit-Change-Number: 12830 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Mon, 04 Feb 2019 20:00:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
