Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12836 )
Change subject: Stream client: update logging ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12836/1/src/stream.c File src/stream.c: https://gerrit.osmocom.org/#/c/12836/1/src/stream.c@52 PS1, Line 52: cli it's customary to put (cli) in such macros, as you don't know how exactly the 'cli' will be specified by the caller. https://gerrit.osmocom.org/#/c/12836/1/src/stream.c@136 PS1, Line 136: const struct value_string stream_cli_state_names[] = { static? -- To view, visit https://gerrit.osmocom.org/12836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie22a80dcec95998cce0b25053fdf74f23eab6e53 Gerrit-Change-Number: 12836 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 05 Feb 2019 15:06:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
