daniel has posted comments on this change. ( https://gerrit.osmocom.org/12598 )
Change subject: Move enum definition to header file ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h File src/libmsc/smpp_smsc.h: https://gerrit.osmocom.org/#/c/12598/1/src/libmsc/smpp_smsc.h@22 PS1, Line 22: enum esme_bind { I'd sort of like the osmo_* prefix here, but then it's missing in esme_read_state as well...and it's not part of libosmo* -- To view, visit https://gerrit.osmocom.org/12598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71b2512894ec2a71a25f35f07ff4308035d951f9 Gerrit-Change-Number: 12598 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Tue, 05 Feb 2019 15:25:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No