Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12844 )
Change subject: debian: depend on libsctp-dev ...................................................................... Patch Set 1: Code-Review+1 Too bad osmo-msc 0df904dea9106587f40ec379e9cc05ea251beb7e didn't say in the commit description that a new dependency (libsctp) was added. I see in https://packages.debian.org/buster/amd64/libsctp-dev/filelist that libsctp has a pkgconfig file, but I see in src/osmo-msc/Makefile.am that we directly append "-lsctp". We should use .pc file for that, as well as for CFLAGS. -- To view, visit https://gerrit.osmocom.org/12844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I092e95ea970763c4008d3c7ff1b7028042574a64 Gerrit-Change-Number: 12844 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 06 Feb 2019 16:42:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
