Max has posted comments on this change. ( https://gerrit.osmocom.org/12837 )
Change subject: Add stream client/server test ...................................................................... Patch Set 18: Code-Review+2 > I don't really understand why you need the -no-install flag, but then it's > just to compile a test, so... In theory autogenerated libtool wrapper script should be equivalent. Not sure why it made a difference in my case, but using static binary instead of srapper script (effect of -no-install flag) seems like a safe bet anyway. -- To view, visit https://gerrit.osmocom.org/12837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I336f79970982ed8e1d73b73d54fa4c27ba8bce8e Gerrit-Change-Number: 12837 Gerrit-PatchSet: 18 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Sun, 10 Feb 2019 22:30:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
