Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12733 )
Change subject: run.sh: more userfriendly "stale configs" message ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/12733/2/net/tmpl_std/run.sh File net/tmpl_std/run.sh: https://gerrit.osmocom.org/#/c/12733/2/net/tmpl_std/run.sh@7 PS2, Line 7: echo " * Hit ^C and run 'make regen' to regenerate your configs" > Even with the Makefile in place? The idea was, that the user only needs to > remember "make regen" for […] i see it so that the Makefile is just a shim for if you can't remember what is really happening... UI wise it's slightly bad to offer two ways to achieve the same. But since this is just some message in a tool with three users... -- To view, visit https://gerrit.osmocom.org/12733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If225e094619a07a228e0e2f337153ee18cdb420c Gerrit-Change-Number: 12733 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 01:06:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
