Max has posted comments on this change. ( https://gerrit.osmocom.org/12763 )
Change subject: Add OpenVPN probe ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/12763/5/src/osysmon_openvpn.c File src/osysmon_openvpn.c: https://gerrit.osmocom.org/#/c/12763/5/src/osysmon_openvpn.c@263 PS5, Line 263: > Why keeping it until then if it's not longer needed? Do we believe on garbage > collectors now? We use talloc all over the place. It has nothing do to with "believe" - it's just convenient. What's so special about this particular line which caught your attention? -- To view, visit https://gerrit.osmocom.org/12763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4493e19b9a09dcebd289457eacd1719f7f8cc31c Gerrit-Change-Number: 12763 Gerrit-PatchSet: 7 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 15:06:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
