Max has posted comments on this change. ( https://gerrit.osmocom.org/12880 )

Change subject: add OSMO_STRBUF_PRINTF()
......................................................................


Patch Set 2:

(1 comment)

Please clarify.

https://gerrit.osmocom.org/#/c/12880/2/tests/utils/utils_test.c
File tests/utils/utils_test.c:

https://gerrit.osmocom.org/#/c/12880/2/tests/utils/utils_test.c@941
PS2, Line 941: #pragma GCC diagnostic ignored "-Wformat-truncation"
Why is this necessary? Do we have to use it every time alongside with 
OSMO_STRBUF_* as well?



--
To view, visit https://gerrit.osmocom.org/12880
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2497514e26c5e7a5d88985fc7e58343be1a027b2
Gerrit-Change-Number: 12880
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <[email protected]>
Gerrit-Comment-Date: Tue, 12 Feb 2019 11:25:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to