Max has posted comments on this change. ( https://gerrit.osmocom.org/12890 )
Change subject: OML: Fix encoded length value of OML GET ATTRIBUTES ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12890/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/12890/1/src/osmo-bsc/abis_nm.c@1720 PS1, Line 1720: fill_om_fom_hdr(oh, 3+attr_len, NM_MT_GET_ATTR, obj_class, > I guess those 3 bytes are the T and L16 parts of TL16V missing right? You > could explain that in the […] That would be handy indeed: fill_om_fom_hdr() is sometimes called with 2+sizeof(), sometime with explicit number (2, 3, 6, even 0) so it's pretty confusing overall. -- To view, visit https://gerrit.osmocom.org/12890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56068de0bb14a99ec39be587e542e27cddb7d1df Gerrit-Change-Number: 12890 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 14 Feb 2019 11:06:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
