Max has posted comments on this change. ( https://gerrit.osmocom.org/12893 )
Change subject: OML: Store merged attributes of IPA OML Managed Objects ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12893/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/#/c/12893/1/src/common/oml.c@1337 PS1, Line 1337: tp_merged = osmo_tlvp_copy(mo->nm_attr, bts); Can this be moved inside 'success' branch of if()? In this case we won't have to free tp_merged and can drop the else{} branch. -- To view, visit https://gerrit.osmocom.org/12893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75ebda46da9c1fcecc484311bf3833f31c536ee1 Gerrit-Change-Number: 12893 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 14 Feb 2019 11:23:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
