Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/12879 )
Change subject: get_value_string(): guard against NULL
......................................................................
get_value_string(): guard against NULL
get_value_string() conveniently prints the value number to a static buffer if
it is unknown in a value_string array. Do the same if the value_string array
pointer itself is NULL.
If a value string array is user supplied and might be NULL, one could add a
separate NULL check around it; but by making get_value_string() itself guard
against NULL, another static char buffer to print the value number is avoided.
Change-Id: Ie640e9258a959da8f4f9089478de993509853997
---
M src/utils.c
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Max: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/utils.c b/src/utils.c
index 0b2ed31..2d5bcb0 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -73,6 +73,9 @@
{
int i;
+ if (!vs)
+ return NULL;
+
for (i = 0;; i++) {
if (vs[i].value == 0 && vs[i].str == NULL)
break;
--
To view, visit https://gerrit.osmocom.org/12879
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie640e9258a959da8f4f9089478de993509853997
Gerrit-Change-Number: 12879
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
