Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12925 )
Change subject: a_iface: Centralize/wrap BSSAP / N-DATA transmission ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12925/1/tests/msc_vlr/msc_vlr_tests.c File tests/msc_vlr/msc_vlr_tests.c: https://gerrit.osmocom.org/#/c/12925/1/tests/msc_vlr/msc_vlr_tests.c@195 PS1, Line 195: struct osmo_sccp_user { Is g_scu just a hack to prevent conn->a.scu being NULL? I think it's worth having a comment in the code. -- To view, visit https://gerrit.osmocom.org/12925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6159ea72cc8e0650eda6c49544acd65e9c15e817 Gerrit-Change-Number: 12925 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 18 Feb 2019 12:44:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
