Neels Hofmeyr has uploaded this change for review. (
https://gerrit.osmocom.org/12988
Change subject: log: fsm: fix logging of negative T upon timeout
......................................................................
log: fsm: fix logging of negative T upon timeout
fi->T values are int, i.e. can be negative. Do not log them as unsigned, i.e.
print "Timeout of T-1" instead of "Timeout of T4294967295".
Negative T timers are useful to indicate freely invented timer numbers, to
distinguish them from proper 3GPP defined T numbers. So far I was using numbers
like T993210 or T9999 for invented T, but T-1, T-2 etc. is a better solution.
Change-Id: I3a59457623da9309fbbda235fe18fadd1636bff6
---
M src/fsm.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/12988/1
diff --git a/src/fsm.c b/src/fsm.c
index eb457a1..900ada6 100644
--- a/src/fsm.c
+++ b/src/fsm.c
@@ -205,9 +205,9 @@
{
struct osmo_fsm_inst *fi = data;
struct osmo_fsm *fsm = fi->fsm;
- uint32_t T = fi->T;
+ int32_t T = fi->T;
- LOGPFSM(fi, "Timeout of T%u\n", fi->T);
+ LOGPFSM(fi, "Timeout of T%d\n", fi->T);
if (fsm->timer_cb) {
int rc = fsm->timer_cb(fi);
--
To view, visit https://gerrit.osmocom.org/12988
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a59457623da9309fbbda235fe18fadd1636bff6
Gerrit-Change-Number: 12988
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <[email protected]>
