osmith has posted comments on this change. ( https://gerrit.osmocom.org/13006 )
Change subject: hlr.c: forward GSUP messages between clients ...................................................................... Patch Set 1: (1 comment) Build fails, because of the dependency that isn't merged to master yet. https://gerrit.osmocom.org/#/c/13006/1/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/13006/1/src/hlr.c@485 PS1, Line 485: /* FIXME: send message back to sender on failure (new GSUP message type?) */ I could not find any MAP message type for "forward failed" or something similar. Can we just invent a new GSUP message type, which is not in MAP, for this use case? -- To view, visit https://gerrit.osmocom.org/13006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4f345abc877baaf0a8f73b8988e6514d9589bf5 Gerrit-Change-Number: 13006 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 22 Feb 2019 11:02:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
