Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13078 )
Change subject: AMR: add define constants for AMR payload length ...................................................................... Patch Set 1: (1 comment) I would also argue the fix and the "cosmetic" change should be separate patches. Thanks! https://gerrit.osmocom.org/#/c/13078/1/include/osmocom/netif/amr.h File include/osmocom/netif/amr.h: https://gerrit.osmocom.org/#/c/13078/1/include/osmocom/netif/amr.h@86 PS1, Line 86: /* AMR voice frame length (in bytes, rounded), might be good to qualify what kind of length. Length of the AMR codec data after TOC? Length of the RTP payload after RTP header? ... -- To view, visit https://gerrit.osmocom.org/13078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65b5da920d58015b875d6dcf17aacdc04b58955e Gerrit-Change-Number: 13078 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Thu, 28 Feb 2019 10:41:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
